Re: [PATCH v13 5/6] PCI: Unify wait for link active into generic PCI

[poza]

On 2018-04-10 04:55, Keith Busch wrote:
> On Mon, Apr 09, 2018 at 10:41:53AM -0400, Oza Pawandeep wrote:
> > +/**
> > + * pcie_wait_for_link - Wait for link till it's active/inactive
> > + * @pdev: Bridge device
> > + * @active: waiting for active or inactive ?
> > + *
> > + * Use this to wait till link becomes active or inactive.
> > + */
> > +bool pcie_wait_for_link(struct pci_dev *pdev, bool active)
> > +{
> > +	int timeout = 1000;
> > +	bool ret;
> > +	u16 lnk_status;
> > +
> > +	for (;;) {
> > +		pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status);
> > +		ret = !!(lnk_status & PCI_EXP_LNKSTA_DLLLA);
> > +		if (ret == active)
> > +			return true;
> > +		if (timeout <= 0)
> > +			break;
> > +		timeout -= 10;
> > +	}
>
> This is missing an msleep(10) at each iteration.

will take care.

> > +
> > +	pci_info(pdev, "Data Link Layer Link Active not %s in 1000 msec\n",
> > +		 active ? "set" : "cleared");
> > +
> > +	return false;
> > +}