Re: [PATCH v7 3/9] pinctrl: actions: Add Actions S900 pinctrl driver

[Andreas FÃrber]

Am 12.04.2018 um 11:04 schrieb Linus Walleij:
> On Wed, Apr 4, 2018 at 7:22 PM, Manivannan Sadhasivam
> <manivannan.sadhasivam@xxxxxxxxxx> wrote:
> 
>> Add pinctrl driver for Actions Semi S900 SoC. The driver supports
>> pinctrl, pinmux and pinconf functionalities through a range of registers
>> common to both gpio driver and pinctrl driver.
>>
>> Pinmux functionality is available only for the pin groups while the
>> pinconf functionality is available for both pin groups and individual
>> pins.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> 
> Patch applied for v4.18
> 
> GOOD WORK!
> 
> We really need to get this in so that Andreas can work on S500
> patches with this as a base.

No, I refused to do that. If his patches get merged, Mani offered that
he will take care of rebasing/rewriting S500 part.

> 
> If any review comments still remain they can surely be addressed
> with incremental improvement patches.

My biggest problem was/is that Mani designed his structs totally
different from mine, with no explanation why or how they correlate.

Also I had protested against him defining fake pins for the drive
strength. Since I did not have time to review the newer patches yet,
please make sure that this is addressed _before_ merging. Changing the
binding after the fact is a problem!

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer, Jane Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)