Re: [PATCH 0/4] HID: alps: Fix some bugs and improve code around 't4_read_write_register()'

From: Jiri Kosina
Date: Thu Apr 12 2018 - 09:11:08 EST


On Tue, 27 Mar 2018, Jiri Kosina wrote:

> > These patches are untested. Especially, patch 1 slightly changes the behavior
> > of 't4_read_write_register()'.
> > This looks logical to me, but please, review it carefully.
> >
> > Christophe JAILLET (4):
> > HID: alps: Report an error if we receive invalid data in
> > 't4_read_write_register()'
> > HID: alps: Save a memory allocation in 't4_read_write_register()' when
> > writing data
> > HID: alps: Check errors returned by 't4_read_write_register()'
> > HID: alps: Fix some style in 't4_read_write_register()'
> >
> > drivers/hid/hid-alps.c | 27 ++++++++++++++++++++++-----
> > 1 file changed, 22 insertions(+), 5 deletions(-)
>
> Masaki-san,
>
> do you have any comments to Christophe's patchset please?

If there is no feedback, I'll queue the set for 4.18.

Thanks,

--
Jiri Kosina
SUSE Labs