Re: [PATCH] ARM: omap2: Fix build when using split object directories

[Dave Gerlach]

Hi,
On 04/12/2018 04:08 AM, Masahiro Yamada wrote:
> 2018-04-12 17:21 GMT+09:00 Anders Roxell <anders.roxell@xxxxxxxxxx>:
>> On 2018-04-11 16:15, Dave Gerlach wrote:
>>> The sleep33xx and sleep43xx files should not depend on a header file
>>> generated in drivers/memory. Remove this dependency and instead allow
>>> both drivers/memory and arch/arm/mach-omap2 to generate all macros
>>> needed in headers local to their own paths.
>>>
>>> This fixes an issue where the build fail will when using O= to set a
>>> split object directory and arch/arm/mach-omap2 is built before
>>> drivers/memory with the following error:
>>>
>>> .../drivers/memory/emif-asm-offsets.c:1:0: fatal error: can't open drivers/memory/emif-asm-offsets.s for writing: No such file or directory
>>> compilation terminated.
>>>
>>> Fixes: 41d9d44d7258 ("ARM: OMAP2+: pm33xx-core: Add platform code needed for PM")
>>> Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
>>> Reviewed-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>> Signed-off-by: Dave Gerlach <d-gerlach@xxxxxx>
>>
>> Tested-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
>>
>> Maybe we can remove drivers/memory/Makefile.asm-offsets and move those
>> changes into drivers/memory/Makefile ?
> 
> Agree!

Alright, I agree as well, fixed in v2.

Regards,
Dave

> 
> 
> 
>