Re: [PATCH] configfs: inherit file and directory owners
From: kbuild test robot
Date: Fri Apr 13 2018 - 17:03:19 EST
Hi Gwendal,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16 next-20180413]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Gwendal-Grignou/configfs-inherit-file-and-directory-owners/20180414-041333
config: i386-randconfig-x014-201814 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
fs/configfs/inode.c: In function 'alloc_iattr':
>> fs/configfs/inode.c:75:25: error: 'CURRENT_TIME' undeclared (first use in this function); did you mean 'MS_RELATIME'?
sd_iattr->ia_ctime = CURRENT_TIME;
^~~~~~~~~~~~
MS_RELATIME
fs/configfs/inode.c:75:25: note: each undeclared identifier is reported only once for each function it appears in
vim +75 fs/configfs/inode.c
56
57 static struct iattr *alloc_iattr(struct configfs_dirent *sd_parent,
58 struct configfs_dirent *sd)
59 {
60 struct iattr *sd_iattr;
61
62 sd_iattr = kzalloc(sizeof(struct iattr), GFP_KERNEL);
63 if (!sd_iattr)
64 return NULL;
65 /* assign default attributes */
66 sd_iattr->ia_mode = sd->s_mode;
67 if (sd_parent && sd_parent->s_iattr) {
68 sd_iattr->ia_uid = sd_parent->s_iattr->ia_uid;
69 sd_iattr->ia_gid = sd_parent->s_iattr->ia_gid;
70 } else {
71 sd_iattr->ia_uid = GLOBAL_ROOT_UID;
72 sd_iattr->ia_gid = GLOBAL_ROOT_GID;
73 }
74 sd_iattr->ia_atime = sd_iattr->ia_mtime =
> 75 sd_iattr->ia_ctime = CURRENT_TIME;
76 return sd_iattr;
77 }
78
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip