Re: [[PATCH v2] 2/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings

[Taniya Das]

Hello Bjorn,

Thanks for your review comments.

On 4/10/2018 4:28 AM, Bjorn Andersson wrote:
> On Sun 08 Apr 03:32 PDT 2018, Taniya Das wrote:
>
> > From: Amit Nischal <anischal@xxxxxxxxxxxxxx>
> >
> > Add RPMh clock device bindings for Qualcomm Technology Inc's SoCs. These
> > devices would be used for communicating resource state requests to control
> > the clocks managed by RPMh.
> >
> > Signed-off-by: Amit Nischal <anischal@xxxxxxxxxxxxxx>
> > Signed-off-by: Taniya Das <tdas@xxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/clock/qcom,rpmh-clk.txt    | 22 ++++++++++++++++++++++
> >   1 file changed, 22 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt b/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
> > new file mode 100644
> > index 0000000..4ade82b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
> > @@ -0,0 +1,22 @@
> > +Qualcomm Technologies, Inc. RPMh Clocks
> > +-------------------------------------------------------
> > +
> > +Resource Power Manager Hardened (RPMh) manages shared resources on
> > +some Qualcomm Technologies Inc. SoCs. It accepts clock requests from
> > +other hardware subsystems via RSC to control clocks.
> > +
> > +Required properties :
> > +- compatible : shall contain "qcom,rpmh-clk-sdm845"
>
> We have a chance to fix this to Rob's liking, so please make this
> "qcom,sdm845-rpmh-clock" (or maybe "qcom,sdm845-rpmhcc"?)

I would fix  it to "qcom,sdm845-rpmh-clk".

> > +
> > +- #clock-cells : must contain 1
> > +
> > +Example :
> > +
> > +#include <dt-bindings/clock/qcom,rpmh.h>
> > +
> > +	&apps_rsc {
> > +		rpmh: clock-controller {
>
> I believe the clock-controller, the power-domain and the bus-scaler are
> equal contenders of the label "rpmh", so please make it more specific.
> How about "rpmhcc" to mimic previous platforms?

Would update it "rpmhcc".

> > +			compatible = "qcom,rpmh-clk-sdm845";
> > +			#clock-cells = <1>;
> > +		};
> > +	};
>
> Regards,
> Bjorn

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--