Re: [PATCH net] Revert "macsec: missing dev_put() on error in macsec_newlink()"

From: David Miller
Date: Mon Apr 16 2018 - 10:02:18 EST

From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Mon, 16 Apr 2018 13:17:50 +0300

> This patch is just wrong, sorry. I was trying to fix a static checker
> warning and misread the code. The reference taken in macsec_newlink()
> is released in macsec_free_netdev() when the netdevice is destroyed.
> This reverts commit 5dcd8400884cc4a043a6d4617e042489e5d566a9.
> Reported-by: Laura Abbott <labbott@xxxxxxxxxx>
> Fixes: 5dcd8400884c ("macsec: missing dev_put() on error in macsec_newlink()")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Acked-by: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx>
> ---
> I sent this earlier but I messed up the CC list. I've updated the
> commit message as well.

Applied, thanks Dan.