Re: [PATCH v4 13/15] KVM: s390: configure the guest's AP devices

[Halil Pasic]

On 04/16/2018 03:05 PM, Pierre Morel wrote:
>> +staticÂvoidÂvfio_ap_mdev_release(structÂmdev_deviceÂ*mdev)
>> +{
>> +ÂÂÂÂstructÂap_matrix_mdevÂ*matrix_mdevÂ=Âmdev_get_drvdata(mdev);
>> +
>> +ÂÂÂÂkvm_ap_deconfigure_matrix(matrix_mdev->kvm);
>> +ÂÂÂÂkvm_ap_interpret_instructions(matrix_mdev->kvm,Âfalse);
> 
> ThisÂcallÂclearsÂtheÂapieÂinÂKVM.
> ThisÂisÂonlyÂOKÂifÂweÂhaveÂaÂsingleÂdeviceÂpresentÂuntilÂtheÂendÂofÂtheÂVM,
> otherwise AP instructions in the guest will fail after the release until theÂendÂofÂtheÂVM
> orÂuntilÂaÂnewÂdeviceÂisÂplugged.

I agree, this seems wrong.