Re: [PATCH] perf tools: set kernel end address properly

[Kim Phillips]

On Mon, 16 Apr 2018 10:51:25 -0300
Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Em Mon, Apr 16, 2018 at 11:23:45AM +0200, Jiri Olsa escreveu:
> > On Mon, Apr 16, 2018 at 01:22:40PM +0900, Namhyung Kim wrote:
> > > The map_groups__fixup_end() was called to set end addresses of kernel
> > > map and module maps.  But now machine__create_modules() is set the end
> > > address of modules properly so the only remaining piece is the kernel
> > > map.  We can set it with adjacent module's address directly instead of
> > > calling the map_groups__fixup_end().  If there's no module after the
> > > kernel map, the end address will be ~0ULL.
> 
> I wonder if it wouldn't be better to have it as last symbol + PAGE_SIZE
> or something like that...
> 
> But, anyway, Kim, does this fix things for you? Can I have your
> Tested-by?

No, perf test 1 still fails:

vmlinux symtab matches kallsyms: FAILED!

Kim