On Mon, 16 Apr 2018 10:44:53 +0200
Pierre Morel <pmorel@xxxxxxxxxxxxxxxxxx> wrote:
On 15/04/2018 23:22, Tony Krowiak wrote:I don't like the ifdeffery either (especially as there's more later).
If the AP instructions are not available on the linux host, thenI did not give my R-B for this.
AP devices can not be interpreted by the SIE. The AP bus has a
function it uses to determine if the AP instructions are
available. This patch provides a new function that wraps the
AP bus's function to externalize it for use by KVM.
Signed-off-by: Tony Krowiak <akrowiak@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Pierre Morel <pmorel@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Harald Freudenberger <freude@xxxxxxxxxxxxxxxxxx>
arch/s390/include/asm/ap.h | 7 +++++++
arch/s390/include/asm/kvm-ap.h | 23 +++++++++++++++++++++++
arch/s390/kvm/Makefile | 2 +-
arch/s390/kvm/kvm-ap.c | 21 +++++++++++++++++++++
drivers/s390/crypto/ap_bus.c | 6 ++++++
5 files changed, 58 insertions(+), 1 deletions(-)
create mode 100644 arch/s390/include/asm/kvm-ap.h
create mode 100644 arch/s390/kvm/kvm-ap.c
diff --git a/arch/s390/kvm/kvm-ap.c b/arch/s390/kvm/kvm-ap.c
new file mode 100644
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0+
+ * Adjunct Processor (AP) configuration management for KVM guests
+ * Copyright IBM Corp. 2018
+ * Author(s): Tony Krowiak <akrowia@xxxxxxxxxxxxxxxxxx>
please change it or suppress my R-B
I think you should review the way you wrap functions
calling the AP interface.
Having all of them together would simplify code and review.
Consolidating all functions for querying basic ap capabilities sounds
like a good idea. What about collecting them in a ap-util file and
either always building it or selecting it from both zcrypt and kvm?
+ return ap_instructions_installed();
+ return 0;
diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
index 35a0c2b..9d108b6 100644
@@ -210,6 +210,12 @@ int ap_query_configuration(struct ap_config_info *info)
+ return (ap_instructions_available() == 0);
* ap_init_configuration(): Allocate and query configuration array.