Re: [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU

[Robin Murphy]

On 17/04/18 18:36, Hook, Gary wrote:
> On 4/13/2018 7:55 PM, Mehta, Sohil wrote:
> > On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
> > > +struct dentry *iommu_debugfs_setup(void)
> > > +{
> > > +ÂÂÂ if (!debugfs_initialized())
> >
> > This check is probably not needed.
>
> Ah, so it isn't. Thank you.
>
> > > +ÂÂÂÂÂÂÂ return NULL;
> > > +
> > > +ÂÂÂ if (!iommu_debugfs_dir)
> > > +ÂÂÂÂÂÂÂ iommu_debugfs_dir = debugfs_create_dir("iommu",
> > > NULL);
> > > +
> > > +ÂÂÂ if (iommu_debugfs_dir)
> > > +ÂÂÂÂÂÂÂ pr_warn("WARNING: IOMMU DEBUGFS SUPPORT HAS BEEN
> > > ENABLED IN THIS KERNEL\n");
> > > +
> >
> > As this gets called for each IOMMU, do you want to use pr_warn_once?
>
> That works, yes.

Or I guess you could just roll the pr_warn() into the previous if() 
condition, i.e. only warn when the singleton debugfs_dir is actually 
created.

Robin.

> > > +ÂÂÂ return iommu_debugfs_dir;
> > > +}
> > > +EXPORT_SYMBOL_GPL(iommu_debugfs_setup);
> >
> > -Sohil
>
> _______________________________________________
> iommu mailing list
> iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx
> https://lists.linuxfoundation.org/mailman/listinfo/iommu