Re: [PATCH v3 06/10] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

[Jae Hyun Yoo]

Hi Robin,

On 4/17/2018 6:37 AM, Robin Murphy wrote:
> Just a drive-by nit:
>
> On 10/04/18 19:32, Jae Hyun Yoo wrote:
> [...]
> > +#define PECI_CTRL_SAMPLING_MASKÂÂÂÂ GENMASK(19, 16)
> > +#define PECI_CTRL_SAMPLING(x)ÂÂÂÂÂÂ (((x) << 16) & 
> > PECI_CTRL_SAMPLING_MASK)
> > +#define PECI_CTRL_SAMPLING_GET(x)ÂÂ (((x) & PECI_CTRL_SAMPLING_MASK) 
> > >> 16)
>
> FWIW, <linux/bitfield.h> already provides functionality like this, so it 
> might be worth taking a look at FIELD_{GET,PREP}() to save all these 
> local definitions.
>
> Robin.

Yes, that looks better. Thanks a lot for your pointing it out.

Jae