Re: [PATCH 2/2] printk: wake up klogd in vprintk_emit
From: Steven Rostedt
Date: Wed Apr 18 2018 - 11:10:46 EST
On Wed, 18 Apr 2018 17:02:14 +0200
Petr Mladek <pmladek@xxxxxxxx> wrote:
> > Calling wake_up_klogd() will grab the rq lock and give us a A-B<->B-A
> > locking order.
>
> wake_up_klogd() uses the lockless irq_work_queue(). So it is actually
> safe.
I didn't look at the code. OK then we don't need to worry about that.
>
> But the name is confusing. We should rename it.
Yes, I would because the old wake_up_klogd() did do a wakeup. Perhaps
we should name it: kick_klogd().
-- Steve