Re: [PATCH 2/2] hfsplus: fix potential refcnt problem of nls module

[Viacheslav Dubeyko]

On Tue, 2018-04-17 at 15:05 +0800, Chengguang Xu wrote:
> When specifying nls option multiple times in a mount,
> current option parsing will cause inaccurate refcount of nls
> module. Hence, call unload_nls for previous one in this case.
> 
> Signed-off-by: Chengguang Xu <cgxu519@xxxxxxx>


Looks good.

Reviewed-by: Vyacheslav Dubeyko <slava@xxxxxxxxxxx>

Thanks,
Vyacheslav Dubeyko.


> ---
> Âfs/hfsplus/options.c | 4 +++-
> Â1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/hfsplus/options.c b/fs/hfsplus/options.c
> index 047e05c..068d4e2 100644
> --- a/fs/hfsplus/options.c
> +++ b/fs/hfsplus/options.c
> @@ -171,8 +171,10 @@ int hfsplus_parse_options(char *input, struct
> hfsplus_sb_info *sbi)
> Â				return 0;
> Â			}
> Â			p = match_strdup(&args[0]);
> -			if (p)
> +			if (p) {
> +				unload_nls(sbi->nls);
> Â				sbi->nls = load_nls(p);
> +			}
> Â			if (!sbi->nls) {
> Â				pr_err("unable to load nls mapping
> \"%s\"\n",
> Â				ÂÂÂÂÂÂÂp);