Re: [PATCH 2/2] selftests: sparc64: char: Selftest for privileged ADI driver

From: Tom Hromatka
Date: Wed Apr 18 2018 - 16:03:55 EST




On 04/18/2018 01:58 PM, Shuah Khan wrote:
Hi Tom,

On 04/18/2018 10:29 AM, Tom Hromatka wrote:
Add a selftest for the sparc64 privileged ADI driver. These
tests verify the read(), pread(), write(), pwrite(), and seek()
functionality of the driver. The tests also report simple
performance statistics:

Syscall Call AvgTime AvgSize
Count (ticks) (bytes)
-------------------------------
read 3 167134 8133
pread 4 137217 6741
write 3 73787 8133
pwrite 4 65832 6741
seek 10 2422 0

Ran 8 tests
All tests passed

Signed-off-by: Tom Hromatka <tom.hromatka@xxxxxxxxxx>
Reviewed-by: Allen Pais <allen.pais@xxxxxxxxxx>
Thanks for the patch. A few comments below:

Thanks for the quick turnaround, Shuah. I'll work through your
comments and get a v2 out in the next few days.

Regards.

Tom