Re: [PATCH v2 2/3] ASoC: amd: dma driver changes for BT I2S instance

From: Daniel Kurtz
Date: Wed Apr 18 2018 - 20:27:22 EST


Hi Vijendar,

On Wed, Apr 18, 2018 at 5:02 AM Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx>
wrote:

> With in ACP, There are three I2S controllers can be
> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
> Default enabled I2S controller instance is I2S SP.
> This patch provides required changes to support I2S BT
> controller Instance.

I like the direction this patch is taking, but I think it would be easier
to review if you could split it into 2 parts:
(1) the cleanup of the existing driver to use a simplified flow for
playback vs capture paths.
(2) adding the BT I2S channel.


Thanks,
-Dan