Re: [PATCH] bpf, x86_32: add eBPF JIT compiler for ia32 (x86_32)

From: Thomas Gleixner
Date: Thu Apr 19 2018 - 07:11:36 EST


On Wed, 18 Apr 2018, Wang YanQing wrote:
> @@ -0,0 +1,147 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* bpf_jit.S : BPF JIT helper functions

Please do not add these file names to the top level comment. They provide
no value and just become stale when the file gets moved/renamed.

> + *
> + * Copyright (C) 2018 Wang YanQing (udknight@xxxxxxxxx)
> + * Copyright (C) 2011 Eric Dumazet (eric.dumazet@xxxxxxxxx)
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; version 2
> + * of the License.

You have already the License Identifier. So you don't need the boiler plate
text.

Thanks,

tglx