Re: [PATCH 1/2] blkcg: small fix on comment in blkcg_init_queue
From: Jens Axboe
Date: Thu Apr 19 2018 - 13:23:50 EST
On 4/19/18 11:10 AM, Randy Dunlap wrote:
> On 04/19/18 07:52, Jens Axboe wrote:
>> On 4/18/18 10:04 PM, Jiang Biao wrote:
>>> The comment before blkg_create() in blkcg_init_queue() was moved
>>> from blkcg_activate_policy() by commit ec13b1d6f0a0457312e615, but
>>> it does not suit for the new context.
>>
>> Applied - btw, in the future, if you send more than one patch in
>> a series, please include a cover letter.
>
> Hi Jens,
>
> Where does that cover letter requirement come from? It's not documented
> anywhere AFAICT and shouldn't be needed for such small patch series.
It's not a requirement, I just strongly prefer it for anything that is
more than one patch. Hence I tend to let people know about that
preference, if they send patches more than once.
It makes it possible to send comments for the series as a whole.
--
Jens Axboe