Re: [PATCH v3 5/7] drm/i2c: tda998x: find the drm_device via the drm_connector

From: Laurent Pinchart
Date: Fri Apr 20 2018 - 05:41:10 EST


Hi Peter,

Thank you for the patch.

On Thursday, 19 April 2018 19:27:49 EEST Peter Rosin wrote:
> This prepares for being a drm_bridge which will not register the
> encoder. That makes the connector the better choice.
>
> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
> b/drivers/gpu/drm/i2c/tda998x_drv.c index cd3f0873bbdd..8f6e013f2b87 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -630,7 +630,7 @@ static void tda998x_detect_work(struct work_struct
> *work) {
> struct tda998x_priv *priv =
> container_of(work, struct tda998x_priv, detect_work);
> - struct drm_device *dev = priv->encoder.dev;
> + struct drm_device *dev = priv->connector.dev;
>
> if (dev)
> drm_kms_helper_hotplug_event(dev);


--
Regards,

Laurent Pinchart