RE: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.

[Mario.Limonciello]

> -----Original Message-----
> From: platform-driver-x86-owner@xxxxxxxxxxxxxxx [mailto:platform-driver-x86-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Randy Dunlap
> Sent: Friday, April 20, 2018 12:53 PM
> To: Limonciello, Mario; dvhart@xxxxxxxxxxxxx; Andy Shevchenko
> Cc: LKML; platform-driver-x86@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.
> 
> On 04/20/18 10:42, Mario Limonciello wrote:
> > As reported by Randy Dunlap:
> >>> WARNING: unmet direct dependencies detected for DELL_SMBIOS
> >>>   Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y]
> >>> 	&& (DCDBAS [=m] ||
> >>> DCDBAS [=m]=n) && (ACPI_WMI [=n] || ACPI_WMI [=n]=n)
> >>>   Selected by [y]:
> >>>   - DELL_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y]
> >>> && DMI [=y]
> >>> && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] ||
> >>> 	ACPI_VIDEO [=n]=n)
> >>> && (RFKILL [=n] || RFKILL [=n]=n) && SERIO_I8042 [=y]
> >>>
> >
> > Right now it's possible to set dell laptop to compile in but this
> > causes dell-smbios to compile in which breaks if dcdbas is a module.
> >
> > Dell laptop shouldn't select dell-smbios anymore, but depend on it.
> >
> > Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve dependency error on
> DCDBAS)
> 
> meta-comment: the SHA-1 ID should be the first 12 characters of the commit ID
> according to Documentation/process/submitting-patches.rst.

Thanks for letting me, I didn't realize that.

Darren, let me know if you want me to resubmit with this adjustment or if you
can adjust when you queue for testing.

> 
> 
> > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx>
> 
> Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> 
> Thanks.
> 
> > ---
> >  drivers/platform/x86/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index 39d06dd..bc309c5 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -154,7 +154,7 @@ config DELL_LAPTOP
> >  	depends on ACPI_VIDEO || ACPI_VIDEO = n
> >  	depends on RFKILL || RFKILL = n
> >  	depends on SERIO_I8042
> > -	select DELL_SMBIOS
> > +	depends on DELL_SMBIOS
> >  	select POWER_SUPPLY
> >  	select LEDS_CLASS
> >  	select NEW_LEDS
> >
> 
> 
> --
> ~Randy