Re: [PATCH v4] tracing: remove igrab() iput() call from uprobes.c

From: Song Liu
Date: Fri Apr 20 2018 - 14:36:55 EST




> On Apr 20, 2018, at 11:29 AM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Fri, 20 Apr 2018 11:08:47 -0700
> Song Liu <songliubraving@xxxxxx> wrote:
>
>> For uprobes.c sisde, igrab() is not necessary. So we removed it and
>
> You don't need to send another patch, but what is the above sentence
> suppose to say?
>
> -- Steve
>

Sorry for the typo. I meant "For uprobes.c side". Or "it is not necessary
to call igrab() in uprobe_register(), as the caller is required to keep
the inode reference.

Song


>> added comments on requirements to callers of uprobe_register().