Re: [PATCH v2] clk: add duty cycle support

From: kbuild test robot
Date: Fri Apr 20 2018 - 15:48:03 EST


Hi Jerome,

I love your patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on v4.17-rc1 next-20180420]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Jerome-Brunet/clk-add-duty-cycle-support/20180421-021133
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: x86_64-randconfig-x016-201815 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All error/warnings (new ones prefixed by >>):

In file included from include/trace/events/clk.h:19:0,
from drivers//clk/clk.c:84:
include/trace/events/clk.h: In function 'trace_clk_set_duty_cycle':
>> include/trace/events/clk.h:221:16: error: 'num' undeclared (first use in this function)
TP_ARGS(core, num, den)
^
include/linux/tracepoint.h:148:33: note: in definition of macro '__DO_TRACE'
((void(*)(proto))(it_func))(args); \
^~~~
>> include/linux/tracepoint.h:189:5: note: in expansion of macro 'TP_ARGS'
TP_ARGS(data_args), \
^~~~~~~
include/linux/tracepoint.h:349:2: note: in expansion of macro '__DECLARE_TRACE'
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^~~~~~~~~~~~~~~
include/linux/tracepoint.h:352:4: note: in expansion of macro 'PARAMS'
PARAMS(__data, args))
^~~~~~
include/linux/tracepoint.h:474:2: note: in expansion of macro 'DECLARE_TRACE'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~~~~~~~~
include/linux/tracepoint.h:474:37: note: in expansion of macro 'PARAMS'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~
>> include/trace/events/clk.h:217:1: note: in expansion of macro 'DEFINE_EVENT'
DEFINE_EVENT(clk_duty_cycle, clk_set_duty_cycle,
^~~~~~~~~~~~
>> include/trace/events/clk.h:221:2: note: in expansion of macro 'TP_ARGS'
TP_ARGS(core, num, den)
^~~~~~~
include/trace/events/clk.h:221:16: note: each undeclared identifier is reported only once for each function it appears in
TP_ARGS(core, num, den)
^
include/linux/tracepoint.h:148:33: note: in definition of macro '__DO_TRACE'
((void(*)(proto))(it_func))(args); \
^~~~
>> include/linux/tracepoint.h:189:5: note: in expansion of macro 'TP_ARGS'
TP_ARGS(data_args), \
^~~~~~~
include/linux/tracepoint.h:349:2: note: in expansion of macro '__DECLARE_TRACE'
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^~~~~~~~~~~~~~~
include/linux/tracepoint.h:352:4: note: in expansion of macro 'PARAMS'
PARAMS(__data, args))
^~~~~~
include/linux/tracepoint.h:474:2: note: in expansion of macro 'DECLARE_TRACE'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~~~~~~~~
include/linux/tracepoint.h:474:37: note: in expansion of macro 'PARAMS'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~
>> include/trace/events/clk.h:217:1: note: in expansion of macro 'DEFINE_EVENT'
DEFINE_EVENT(clk_duty_cycle, clk_set_duty_cycle,
^~~~~~~~~~~~
>> include/trace/events/clk.h:221:2: note: in expansion of macro 'TP_ARGS'
TP_ARGS(core, num, den)
^~~~~~~
>> include/trace/events/clk.h:221:21: error: 'den' undeclared (first use in this function)
TP_ARGS(core, num, den)
^
include/linux/tracepoint.h:148:33: note: in definition of macro '__DO_TRACE'
((void(*)(proto))(it_func))(args); \
^~~~
>> include/linux/tracepoint.h:189:5: note: in expansion of macro 'TP_ARGS'
TP_ARGS(data_args), \
^~~~~~~
include/linux/tracepoint.h:349:2: note: in expansion of macro '__DECLARE_TRACE'
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^~~~~~~~~~~~~~~
include/linux/tracepoint.h:352:4: note: in expansion of macro 'PARAMS'
PARAMS(__data, args))
^~~~~~
include/linux/tracepoint.h:474:2: note: in expansion of macro 'DECLARE_TRACE'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~~~~~~~~
include/linux/tracepoint.h:474:37: note: in expansion of macro 'PARAMS'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~
>> include/trace/events/clk.h:217:1: note: in expansion of macro 'DEFINE_EVENT'
DEFINE_EVENT(clk_duty_cycle, clk_set_duty_cycle,
^~~~~~~~~~~~
>> include/trace/events/clk.h:221:2: note: in expansion of macro 'TP_ARGS'
TP_ARGS(core, num, den)
^~~~~~~
>> include/linux/tracepoint.h:148:6: error: too many arguments to function '(void (*)(void *, struct clk_core *, struct clk_duty *))it_func'
((void(*)(proto))(it_func))(args); \
~^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:187:4: note: in expansion of macro '__DO_TRACE'
__DO_TRACE(&__tracepoint_##name, \
^~~~~~~~~~
include/linux/tracepoint.h:349:2: note: in expansion of macro '__DECLARE_TRACE'
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^~~~~~~~~~~~~~~
include/linux/tracepoint.h:474:2: note: in expansion of macro 'DECLARE_TRACE'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~~~~~~~~
>> include/trace/events/clk.h:217:1: note: in expansion of macro 'DEFINE_EVENT'
DEFINE_EVENT(clk_duty_cycle, clk_set_duty_cycle,
^~~~~~~~~~~~
include/trace/events/clk.h: In function 'trace_clk_set_duty_cycle_rcuidle':
>> include/trace/events/clk.h:221:16: error: 'num' undeclared (first use in this function)
TP_ARGS(core, num, den)
^
include/linux/tracepoint.h:148:33: note: in definition of macro '__DO_TRACE'
((void(*)(proto))(it_func))(args); \
^~~~
include/linux/tracepoint.h:163:5: note: in expansion of macro 'TP_ARGS'
TP_ARGS(data_args), \
^~~~~~~
include/linux/tracepoint.h:197:2: note: in expansion of macro '__DECLARE_TRACE_RCU'
__DECLARE_TRACE_RCU(name, PARAMS(proto), PARAMS(args), \
^~~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:198:37: note: in expansion of macro 'PARAMS'
PARAMS(cond), PARAMS(data_proto), PARAMS(data_args)) \
^~~~~~
include/linux/tracepoint.h:349:2: note: in expansion of macro '__DECLARE_TRACE'
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^~~~~~~~~~~~~~~
include/linux/tracepoint.h:352:4: note: in expansion of macro 'PARAMS'
PARAMS(__data, args))
^~~~~~
include/linux/tracepoint.h:474:2: note: in expansion of macro 'DECLARE_TRACE'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~~~~~~~~
include/linux/tracepoint.h:474:37: note: in expansion of macro 'PARAMS'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~
>> include/trace/events/clk.h:217:1: note: in expansion of macro 'DEFINE_EVENT'
DEFINE_EVENT(clk_duty_cycle, clk_set_duty_cycle,
^~~~~~~~~~~~
>> include/trace/events/clk.h:221:2: note: in expansion of macro 'TP_ARGS'
TP_ARGS(core, num, den)
^~~~~~~
>> include/trace/events/clk.h:221:21: error: 'den' undeclared (first use in this function)
TP_ARGS(core, num, den)
^
include/linux/tracepoint.h:148:33: note: in definition of macro '__DO_TRACE'
((void(*)(proto))(it_func))(args); \
^~~~
include/linux/tracepoint.h:163:5: note: in expansion of macro 'TP_ARGS'
TP_ARGS(data_args), \
^~~~~~~
include/linux/tracepoint.h:197:2: note: in expansion of macro '__DECLARE_TRACE_RCU'
__DECLARE_TRACE_RCU(name, PARAMS(proto), PARAMS(args), \
^~~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:198:37: note: in expansion of macro 'PARAMS'
PARAMS(cond), PARAMS(data_proto), PARAMS(data_args)) \
^~~~~~
include/linux/tracepoint.h:349:2: note: in expansion of macro '__DECLARE_TRACE'
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^~~~~~~~~~~~~~~
include/linux/tracepoint.h:352:4: note: in expansion of macro 'PARAMS'
PARAMS(__data, args))
^~~~~~
include/linux/tracepoint.h:474:2: note: in expansion of macro 'DECLARE_TRACE'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~~~~~~~~
include/linux/tracepoint.h:474:37: note: in expansion of macro 'PARAMS'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~
>> include/trace/events/clk.h:217:1: note: in expansion of macro 'DEFINE_EVENT'
DEFINE_EVENT(clk_duty_cycle, clk_set_duty_cycle,
^~~~~~~~~~~~
>> include/trace/events/clk.h:221:2: note: in expansion of macro 'TP_ARGS'
TP_ARGS(core, num, den)
^~~~~~~
>> include/linux/tracepoint.h:148:6: error: too many arguments to function '(void (*)(void *, struct clk_core *, struct clk_duty *))it_func'
((void(*)(proto))(it_func))(args); \
~^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:161:4: note: in expansion of macro '__DO_TRACE'
__DO_TRACE(&__tracepoint_##name, \
^~~~~~~~~~
include/linux/tracepoint.h:197:2: note: in expansion of macro '__DECLARE_TRACE_RCU'
__DECLARE_TRACE_RCU(name, PARAMS(proto), PARAMS(args), \
^~~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:349:2: note: in expansion of macro '__DECLARE_TRACE'
__DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
^~~~~~~~~~~~~~~
include/linux/tracepoint.h:474:2: note: in expansion of macro 'DECLARE_TRACE'
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^~~~~~~~~~~~~

vim +/num +221 include/trace/events/clk.h

194
> 195 DECLARE_EVENT_CLASS(clk_duty_cycle,
196
197 TP_PROTO(struct clk_core *core, struct clk_duty *duty),
198
> 199 TP_ARGS(core, num, den),
200
> 201 TP_STRUCT__entry(
> 202 __string( name, core->name )
> 203 __field( unsigned int, duty->num )
204 __field( unsigned int, duty->den )
205 ),
206
> 207 TP_fast_assign(
208 __assign_str(name, core->name);
209 __entry->num = num;
210 __entry->den = den;
211 ),
212
> 213 TP_printk("%s %u/%u", __get_str(name), (unsigned int)__entry->num,
> 214 (unsigned int)__entry->den)
215 );
216
> 217 DEFINE_EVENT(clk_duty_cycle, clk_set_duty_cycle,
218
219 TP_PROTO(struct clk_core *core, struct clk_duty *duty),
220
> 221 TP_ARGS(core, num, den)
222 );
223
> 224 DEFINE_EVENT(clk_duty_cycle, clk_set_duty_cycle_complete,
225
226 TP_PROTO(struct clk_core *core, struct clk_duty *duty),
227
228 TP_ARGS(core, num, den)
229 );
230
231 #endif /* _TRACE_CLK_H */
232
233 /* This part must be outside protection */
> 234 #include <trace/define_trace.h>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip