Re: [PATCH v4 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

From: Andy Shevchenko
Date: Mon Apr 23 2018 - 09:44:01 EST


On Fri, Apr 20, 2018 at 12:44 PM, Kai-Heng Feng
<kai.heng.feng@xxxxxxxxxxxxx> wrote:
> On some Dell platforms, there's a BIOS option "Enable Switchable
> Graphics". This information is useful if we want to do different things
> based on this value, e.g. disable unused audio controller that comes
> with the discrete graphics.

> int dell_micmute_led_set(int on);
> +bool dell_switchable_gfx_is_enabled(void);

I would rather preserve existing API, i.e.
- prototype int func(void), where return either state or negative error code.
- naming: dell_switchable_gfx_get()

--
With Best Regards,
Andy Shevchenko