Re: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

[Hans de Goede]

Hi,

On 24-04-18 09:42, Chanwoo Choi wrote:
> On 2018ë 04ì 17ì 18:01, Hans de Goede wrote:
> > Hi,
> >
> > On 17-04-18 07:14, Randy Dunlap wrote:
> > > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > >
> > > The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
> > > Makefile does not currently build drivers/usb/common/ (where
> > > USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
> > > the USB Makefile to always descend into drivers/usb/common/
> > > to build its configured targets.
> > >
> > > Fixes these build errors:
> > >
> > > ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
> > > ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
> > > ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
> > > ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
> > >
> > > An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
> > > driver Kconfig entry, but this would build more code in
> > > drivers/usb/common/ than is necessary.
> >
> > Ah, that variant of fixing this got posted yesterday and I acked that,
> > but I agree that this version is better.
> >
> > Greg, what is your take on this fix?
> >
> > Chanwoo Choi, please wait with merging the fix from yesterday until
> > we've a decision which fix to use.
>
> OK. I'll not send pull request for fix patches until deciding them.

Greg has picked up another patch to fix this, so you can drop this.

Regards,

Hans