Re: [RESEND PATCH] media: i2c: ov5640: Add pixel clock support
From: Sakari Ailus
Date: Tue Apr 24 2018 - 06:33:12 EST
On Tue, Apr 24, 2018 at 11:01:18AM +0200, Loic Poulain wrote:
> On 29 March 2018 at 16:55, Manivannan Sadhasivam
> <manivannan.sadhasivam@xxxxxxxxxx> wrote:
> > Some of the camera subsystems like camss in Qualcommm MSM chipsets
> > require pixel clock support in camera sensor drivers. So, this commit
> > adds a default pixel clock rate of 96MHz to OV5640 camera sensor driver.
> > According to the datasheet, 96MHz can be used as a pixel clock rate for
> > most of the modes.
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> Tested-by: Loic Poulain <loic.poulain@xxxxxxxxxx>
> It works for me on Dragonboard 410c + D3 camera mezzanine (ov5640) .
> Any comments on this change?
There's also another set that adds PIXEL_CLOCK (as well as LINK_FREQ)
support to the driver, that seems more complete than this patch but
requires a rebase on Maxime's patches: