Re: [PATCH] perf tools: set kernel end address properly
From: Kim Phillips
Date: Tue Apr 24 2018 - 08:50:17 EST
On Tue, 24 Apr 2018 08:13:57 +0200
Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote:
> On 23 April 2018 at 23:43, Kim Phillips <kim.phillips@xxxxxxx> wrote:
> > arch__normalize_symbol_name() is a place where architecture code can
> > clean up symbol names in perf, and I thought module_emit_adrp_veneer()
> > was a veneer itself, but it seems that's not the case, so the
> > literal string check for it shouldn't be needed. The test is still
> > failing though because it doesn't show up in kallsyms...
>
> This turns out to be an unintended side effect of the fact that we
> (I?) taught kallsyms to disregard symbols ending in "_veneer"
>
> So we should probably rename the function, and everything will be fine.
ok so what should we rename module_emit_adrp_veneer to?:
module_emit_adrp_veneer_
module_emit_adrp_veneer_fn
module_emit_adrp_veneer_nokallsyms
or..?
Kim