Re: [PATCH] do not call trace_printk on non-debug build

From: Steven Rostedt
Date: Tue Apr 24 2018 - 14:51:08 EST


On Tue, 24 Apr 2018 11:08:10 -0700
Wei Wang <wvw@xxxxxxxxxx> wrote:

> From: Wei Wang <wvw@xxxxxxxxxx>
>
> trace_printk will cause trace_printk_init_buffers executed in kernel
> start, which will increase memory and also show bad warnings in
> production kernel.
>

NAK!

Where is trace_printk() being used to trigger this?

trace_printk() is to be added while debugging, but one should not need
to enable DEBUG to use it. But it should be removed when finished.

-- Steve

> Signed-off-by: Wei Wang <wvw@xxxxxxxxxx>