Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver

From: David Collins
Date: Tue Apr 24 2018 - 16:36:54 EST

>>>>>> + ret = cmd_db_ready();
>>>>>> + if (ret < 0) {
>>>>>> + if (ret != -EPROBE_DEFER)
>>>>>> + dev_err(dev, "Command DB not available,
>>>>>> ret=%d\n", ret);
>>>>>> + return ret;
>>>>>> + }
>>>>> We should just make rpmh parent device call cmd_db_ready() so that these
>>>>> devices aren't even populated until then and so that cmd_db_ready() is
>>>>> only in one place. Lina?
>>>> Let's see if Lina has qualms about this plan.
>>> Sounds like you're ok with it.
>> Sure, I'll remove this check if Lina agrees to add it in the rpmh driver.
> We want to make the RSC nodes child of Command DB? That way we probe the
> controllers only if the command DB is ready?
> I could do that. Just so you know, there is are no strict directives to
> use Command DB. If a driver knows the information it needs to pass to
> the accelerator, it may choose to skip command DB completely.

The ask here is for the rpmh driver to call cmd_db_ready() in its probe
function and return any error encountered (e.g. -EPROBE_DEFER).

I suppose that specifying the rpmh rsc device tree node as a child inside
of the command DB node could achieve the same result. However, that seems
a little hacky as the rsc device is describing a hardware block physically
found on the SoC as opposed to a subcomponent of the command DB SMEM data
structure. I defer to device tree maintainers to comment on the
acceptability of this approach.

While technically it is possible for an rpmh consumer to intrinsically
know the addresses for its resources without polling command DB, do you
have any examples where this is the case?


The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project