Re: [uml-devel] [REVIEW][PATCH 19/22] signal/um: Use force_sig_fault in relay_signal.

From: Martin PÃrtel
Date: Tue Apr 24 2018 - 18:03:44 EST


And once more in plain text..

On 25 April 2018 at 01:00, Martin PÃrtel <martin.partel@xxxxxxxxx> wrote:
>
> Hi all,
>
> This was ages ago, but from what I remember...
>
>>
>> Having a second look I really don't understand what relay_signal is
>> trying to do.
>>
>> The function relay_signal does not pass siginfo through unchanged.
>
>
> Just copying the entire struct would do the wrong thing. It was discussed here:
> https://marc.info/?l=user-mode-linux-devel&m=133910707911999&w=2
>
>>
>> Am I missing something subtle or have the subtle details of siginfo just
>> always been ignored?
>
>
> My guess is they have. I was almost certainly oblivious to such subtleties when writing my commit.
>