Re: [PATCH 2/5] ide: kill ide_toggle_bounce
From: Jens Axboe
Date: Tue Apr 24 2018 - 22:03:16 EST
On 4/24/18 12:16 PM, Christoph Hellwig wrote:
> ide_toggle_bounce did select various strange block bounce limits, including
> not bouncing at all as soon as an iommu is present in the system. Given
> that the dma_map routines now handle any required bounce buffering except
> for ISA DMA, and the ide code already must handle either ISA DMA or highmem
> at least for iommu equipped systems we can get rid of the block layer
> bounce limit setting entirely.
Pretty sure I was the one to add this code, when highmem page IO was
enabled about two decades ago...
Outside of DMA, the issue was that the PIO code could not handle
highmem. That's not the case anymore, so this should be fine.
Reviewed-by: Jens Axboe <axboe@xxxxxxxxx>