Re: [PATCH] time: tick-sched: use bool for tick_stopped

From: yuankuiz
Date: Wed Apr 25 2018 - 03:01:52 EST


On 2018-04-21 03:24 AM, Joe Perches wrote:
On Fri, 2018-04-20 at 14:44 +0800, yuankuiz@xxxxxxxxxxxxxx wrote:
On 2018-04-20 09:47 AM, yuankuiz@xxxxxxxxxxxxxx wrote:
[]
> [ZJ] Further prototyping has been given based on gcc for both of
> x86_64 and armv8-a,
> unsigned int and bool share the same 1 bytes without the
> addtional storage for sure.
> Open this and welcome if any other difference behaviour could be
> captured.

[ZJ] Typo.. change 4 bytes above to 1 byte actually.

Not really.

unsigned int is 4 and bool is generally 1.
Alignment padding after a bool may exist.
[ZJ] Depending on how to pack, the size was padded is variance. For example.
In case of the "unsigned char" at the following, pack is happened and result 1 bytes.(if no more than 8 bits are used)
In case of the "int" at the following, pack is happened but result 4 bytes.
I mean, I demo it but use the 1# case due for another thread discussion on the ichx_desc() so move a little bit from the tick_sched struct.