Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

From: Daniel Vetter
Date: Wed Apr 25 2018 - 03:02:25 EST

On Wed, Apr 25, 2018 at 8:43 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Wed, Apr 25, 2018 at 08:23:15AM +0200, Daniel Vetter wrote:
>> For more fun:
>> Yeah, sometimes we want to disable the iommu because the on-gpu
>> pagetables are faster ...
> I am not on this list, but remote NAK from here. This needs an
> API from the iommu/dma-mapping code. Drivers have no business poking
> into these details.

Can we please not nack everything right away? Doesn't really motivate
me to show you all the various things we're doing in gpu to make the
dma layer work for us. That kind of noodling around in lower levels to
get them to do what we want is absolutely par-for-course for gpu
drivers. If you just nack everything I point you at for illustrative
purposes, then I can't show you stuff anymore.

Just to make it clear: I do want to get this stuff sorted, and it's
awesome that someone from core finally takes a serious look at what
gpu folks have been doing for decades (instead of just telling us
we're incompetent and doing it all wrong and then steaming off), and
how to make this work without layering violations to no end. But
stopping the world until this is fixed isn't really a good option.

Thanks, Daniel

> Thierry, please resend this with at least the iommu list and
> linux-arm-kernel in Cc to have a proper discussion on the right API.

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 -