Re: [PATCH 3/7] gnss: add generic serial driver

From: Greg Kroah-Hartman
Date: Wed Apr 25 2018 - 05:00:45 EST

On Tue, Apr 24, 2018 at 06:34:54PM +0200, Johan Hovold wrote:
> +static inline void *gnss_serial_get_drvdata(struct gnss_serial *gserial)
> +{
> + return &gserial[1];
> +}

Oh that's the best hack I have seen in a long time. I need to remember
that one for next time.

Anyway, in reading this driver, I don't think the module reference
counting is being handled here, so you might want to add that to the
gnss core to keep things from going south if modules are unloaded.


greg k-h