Re: [PATCH v3 2/3] regulator: add support for SY8106A regulator
From: Icenowy Zheng
Date: Wed Apr 25 2018 - 06:56:03 EST
ä 2018å4æ25æ GMT+08:00 äå6:53:09, Mark Brown <broonie@xxxxxxxxxx> åå:
>On Wed, Apr 25, 2018 at 07:41:35AM +0800, Icenowy Zheng wrote:
>> ä 2018å4æ25æ GMT+08:00 äå1:07:33, Mark Brown <broonie@xxxxxxxxxx> åå:
>> >On Mon, Apr 23, 2018 at 10:46:56PM +0800, Icenowy Zheng wrote:
>> >> --- /dev/null
>> >> +++ b/drivers/regulator/sy8106a-regulator.c
>> >> @@ -0,0 +1,176 @@
>> >> +// SPDX-License-Identifier: GPL-2.0+
>> >> +/*
>> >> + * sy8106a-regulator.c - Regulator device driver for SY8106A
>> >Just make the entire thing a C++ comment so it looks consistent and
>> >joined up.
>> SPDX identifier is special -- it should be in a seperated
>> comment block.
>No, it just needs to be a C++ comment on the first line to ease machine
>parsing. The rest of the file doesn't matter for that.
Okay. Thus I will use a seperate /* */ block for it in the
next revision, to follow the rule.
>> >> + if (reg & SY8106A_GO_BIT)
>> >> + return reg & rdev->desc->vsel_mask;
>> >> + else
>> >> + return (chip->fixed_voltage - rdev->desc->min_uV) /
>> >> + rdev->desc->uV_step;
>> >You could use the standard get_voltage_sel() if you provide a
>> >operation that set everything with _GO_BIT set to return the fixed
>> >voltage. Though looking at this it seems that the fixed voltage
>> >always be one that could be set via the register anyway so I'm
>> >if the easiest thing here isn't to just have the driver turn off
>> Do you mean "turn on" here?
Okay. I will do it in this way and drop custom get/set_voltage_sel.