Re: [PATCH 03/10] vfio: ccw: new SCH_EVENT event

From: Pierre Morel
Date: Wed Apr 25 2018 - 09:54:35 EST

On 25/04/2018 10:25, Cornelia Huck wrote:
On Thu, 19 Apr 2018 16:48:06 +0200
Pierre Morel <pmorel@xxxxxxxxxxxxxxxxxx> wrote:

The Sub channel event callback is threaded using workqueues.
The work uses the FSM introducing the VFIO_CCW_EVENT_SCH_EVENT
I don't think this is a good name; after all, all of the events are
events for the subchannel :)

This seems to be more of a "we need to update the schib" event...

Tbh, I'm not quite sure this makes sense for me yet... will continue
reading, but this probably needs a 'why'.

SCHIB_CHANGED or something like this sounds better indeed. :)

The update of the SCHIB is now done inside the FSM function.

Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxxxxxxx>
drivers/s390/cio/vfio_ccw_drv.c | 33 +++++++++++++--------------------
drivers/s390/cio/vfio_ccw_fsm.c | 23 +++++++++++++++++++++++
drivers/s390/cio/vfio_ccw_private.h | 3 +++
3 files changed, 39 insertions(+), 20 deletions(-)

Pierre Morel
Linux/KVM/QEMU in BÃblingen - Germany