Re: [PATCH 0/6] virtio-console: spec compliance fixes

From: Amit Shah
Date: Wed Apr 25 2018 - 10:02:06 EST




On 24 April 2018 11:41:29 AM GMT-07:00, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
>On Fri, Apr 20, 2018 at 09:17:59PM +0300, Michael S. Tsirkin wrote:
>> Turns out virtio console tries to take a buffer out of an active vq.
>> Works by sheer luck, and is explicitly forbidden by spec. And while
>> going over it I saw that error handling is also broken -
>> failure is easy to trigger if I force allocations to fail.
>>
>> Lightly tested.
>
>Amit - any feedback before I push these patches?

I'm traveling this week, will be able to take a look early next week.

Amit

--
http://amitshah.net