Re: [PATCH v5 09/11] vsprintf: Prevent crash when dereferencing invalid pointers

From: Andy Shevchenko
Date: Wed Apr 25 2018 - 11:33:13 EST


On Wed, 2018-04-25 at 18:10 +0300, Andy Shevchenko wrote:

Some typos fixed

> I would preserve similar style of buf pointer handling, i.e.
>
> static char *valid_pointer_access(char **buf, char *end,

char *buf

> const void *ptr, struct printf_spec
> spec)
> {
> const char *err_msg;
>
> err_msg = check_pointer_access(ptr);
> if (err_msg)
> return = valid_string(*buf, end, err_msg, spec);

return valid_string(buf, end, err_msg, spec);

> return NULL;
> }
>

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy