Re: [PATCH 0/3] Introduce LSM-hook for socketpair(2)

From: Paul Moore
Date: Wed Apr 25 2018 - 14:51:24 EST


On Wed, Apr 25, 2018 at 2:44 PM, James Morris <jmorris@xxxxxxxxx> wrote:
> On Mon, 23 Apr 2018, David Herrmann wrote:
>> This patch series tries to close this gap and makes both behave the
>> same. A new LSM-hook is added which allows LSMs to cache the correct
>> peer information on newly created socket-pairs.
>
> Looks okay to me.
>
> Once it's respun with the Smack backend and maybe the hook name change,
> I'll merge this unless DaveM wants it to go in via his networking tree.

Note my objection to the hook placement in patch 2/3; I think we
should move the hook out of the AF_UNIX layer and up into the socket
layer.

--
paul moore
www.paul-moore.com