Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

From: Jan Kiszka
Date: Wed Apr 25 2018 - 16:09:56 EST

On 2018-04-25 21:53, Geert Uytterhoeven wrote:
> Hi Jan,
> On Wed, Apr 25, 2018 at 9:40 PM, Jan Kiszka <jan.kiszka@xxxxxx> wrote:
>> What other pointers are we talking about?
> There's also the issue that some data has been allocated using kmalloc(),
> while others hasn't. The "other" pointers point to e.g. early bootmem or
> memblock.

Should not be an issue for overlays or of_changesets, should it?

Yes, I've learned the hard way that it is a very bad idea to build
changesets with properties that were not dynamically allocated. Maybe
that is documented somewhere, how the ownership of those objects change
after apply and how they may get handled later on. But now as I know,
it's kind of consistent and rather easy to account for.