Re: [PATCH] staging: fsl-dpaa2/eth: Add support for hardware timestamping

From: Richard Cochran
Date: Wed Apr 25 2018 - 22:33:20 EST

On Wed, Apr 25, 2018 at 05:17:49PM +0800, Yangbo Lu wrote:

> +/* PTP nominal frequency 1GHz */

Nit: Frequency is the inverse of the period. It can be one or the
other, not both.

Why not call it simply DPAA2_PTP_CLK_PERIOD_NS?

You haven't implemented the ethtool_get_ts_info() method, but you need
to do so. Show us how the user can related these MAC time stamps to
the PHC device in your other patch series.