Re: [PATCH 1/2] gpio: eic: Add edge trigger emulation for EIC
From: Uwe Kleine-König
Date: Thu Apr 26 2018 - 04:30:16 EST
On Thu, Apr 26, 2018 at 10:10:11AM +0200, Linus Walleij wrote:
> On Fri, Mar 30, 2018 at 9:02 AM, Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
> > The Spreadtrum debounce EIC and latch EIC can not support edge trigger,
> > but most GPIO users (like gpio-key driver) only use the edge trigger,
> > thus the EIC driver need add some support to emulate the edge trigger
> > to satisfy this requirement.
> > Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
> Patch applied.
> The patch is fine and in line with other kernel drivers doing edge
> trigger emulation and we do not hold back on useful features.
> But I want to take this opportunity to ping Uwe Kleine-König about
> his ideas for an edge trigger emulation library in the gpiolib core,
> and whether this also follows the pattern.
up to now it's still only this: an idea.
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |