Re: [PATCH] proc: use #pragma once
From: David Sterba
Date: Thu Apr 26 2018 - 06:29:13 EST
On Wed, Apr 25, 2018 at 11:55:31PM +0300, Alexey Dobriyan wrote:
> On Tue, Apr 24, 2018 at 06:54:09AM -0700, Christoph Hellwig wrote:
> > On Tue, Apr 24, 2018 at 12:35:34AM +0300, Alexey Dobriyan wrote:
> > > Bring /proc into 21st century.
> >
> > Please explain what this actually buys us except for being pointlessly
> > different from the rest of the kernel?
>
> Negative LOC diff, less junk in preprocessor hashtables.
There are about 20k header files, none of them has #pragma once.
Updating that will bring many unnesessry git commits.
I doubt that one more define in preprocessor tables is a problem we
should fix. The LOC argument also does not sound very convincing. The
include protection is at the top of the file, not mixed among other
code. Replacing 2-3 lines with one will be barely noticeable.