Re: [PATCH v2] gpiolib: add hogs support for machine code
From: Linus Walleij
Date: Thu Apr 26 2018 - 08:07:31 EST
On Tue, Apr 10, 2018 at 10:30 PM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> Board files constitute a significant part of the users of the legacy
> GPIO framework. In many cases they only export a line and set its
> desired value. We could use GPIO hogs for that like we do for DT and
> ACPI but there's no support for that in machine code.
>
> This patch proposes to extend the machine.h API with support for
> registering hog tables in board files.
>
> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
> ---
> v1 -> v2:
> - kbuild bot complains about enum gpiod_flags having incomplete type
> although it builds fine for me locally: change the type of dflags
> to int
I like the idea and thinking behind this patch, so patch applied.
It's a bit of code to carry, so if it doesn't see any use, I will simply
revert it :)
But I bet you intend to follow up with some machine patches
and then it is immediately worth it.
Yours,
Linus Walleij