Re: [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type
From: Luc Van Oostenryck
Date: Thu Apr 26 2018 - 16:00:19 EST
On Wed, Apr 25, 2018 at 06:44:38PM +0200, Janusz Lisiecki wrote:
> Maybe inside ks_wlan_start_xmit, instead of "return 0;", there should be
> "return NETDEV_TX_OK;" and "return NETDEV_TX_BUSY;" otherwise. It is just
I see, yes. However, since:
1) this sort of change is really outside the goal of this patch;
2) more change are needed for returning NETDEV_TX_BUSY (most not
free the skb, probably should stop the queue/device, ...);
3) the driver is actively improving by someone just now (Sergio);
I prefer to let this change to Sergio.
I'll resend my (unimportant) change in a few weeks (if still needed).