Re: [tip:timers/urgent] Revert: Unify CLOCK_MONOTONIC and CLOCK_BOOTTIME

From: Pavel Machek
Date: Thu Apr 26 2018 - 16:38:20 EST


On Wed 2018-04-25 06:45:50, tip-bot for Thomas Gleixner wrote:
> Commit-ID: 757d5a9b3052a4eebd029f207f1e1df59bef7b7d
> Gitweb: https://git.kernel.org/tip/757d5a9b3052a4eebd029f207f1e1df59bef7b7d
> Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> AuthorDate: Wed, 25 Apr 2018 15:33:38 +0200
> Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> CommitDate: Wed, 25 Apr 2018 15:35:08 +0200
>
> Revert: Unify CLOCK_MONOTONIC and CLOCK_BOOTTIME
>
> Revert commits
>
> 92af4dcb4e1c ("tracing: Unify the "boot" and "mono" tracing clocks")
> 127bfa5f4342 ("hrtimer: Unify MONOTONIC and BOOTTIME clock behavior")
> 7250a4047aa6 ("posix-timers: Unify MONOTONIC and BOOTTIME clock behavior")
> d6c7270e913d ("timekeeping: Remove boot time specific code")
> f2d6fdbfd238 ("Input: Evdev - unify MONOTONIC and BOOTTIME clock behavior")
> d6ed449afdb3 ("timekeeping: Make the MONOTONIC clock behave like the BOOTTIME clock")
> 72199320d49d ("timekeeping: Add the new CLOCK_MONOTONIC_ACTIVE clock")
>
> As stated in the pull request for the unification of CLOCK_MONOTONIC and
> CLOCK_BOOTTIME, it was clear that we might have to revert the change.
>
> As reported by several folks systemd and other applications rely on the
> documented behaviour of CLOCK_MONOTONIC on Linux and break with the above
> changes. After resume daemons time out and other timeout related issues are
> observed.
>
> It's sad, that these problems were neither catched in -next nor by those
> folks who expressed interest in this change.
>
> Reported-by: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>
> Reported-by: Genki Sky <sky@xxxxxxxx>,

Tested-by: Pavel Machek <pavel@xxxxxx>

Both screensaver problem and network problems are gone on X60 after I
applied the revert. (I did not do too many tests, but it was normally
too easy to reproduce.)

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature