Re: [PATCH] dt-bindings: pinctrl: mcp23s08: Clarify gpiospec flags cell usage

From: Linus Walleij
Date: Thu Apr 26 2018 - 18:48:44 EST


On Wed, Apr 11, 2018 at 11:42 PM, Ricardo Silva <rjpdasilva@xxxxxxxxx> wrote:

> The pinctrl-mcp23s08 driver doesn't provide a specific gpiospec
> of_xlate() function, causing the gpiolib-of's of_gpio_simple_xlate()
> function to be used instead, which takes the gpiospec's second cell as
> the flags specifier according to 'include/dt-bindings/gpio/gpio.h'.
>
> The pinctrl-mcp23s08 bindings document was mentioning that the flags
> were unused, which is not accurate because values in that second cell
> are indeed used by the gpiolib-of's of_gpio_simple_xlate() for
> configuring the gpio (e.g. its polarity).
>
> This way, replace the "flags currently unused" reference in the
> dt-bindings document with references to the appropriate files specifying
> the possible flag values and gpiospec description.
>
> CC: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Ricardo Silva <rjpdasilva@xxxxxxxxx>

Patch applied with Rob's review tag.

Yours,
Linus Walleij