Re: [PATCH] net: phy: marvell: clear wol event before setting it

From: Bhadram Varka
Date: Thu Apr 26 2018 - 23:53:02 EST

Hi Andrew/Jisheng,

On 4/26/2018 6:10 PM, Andrew Lunn wrote:
hmm, so you want a "stick" WOL feature, I dunno whether Linux kernel
requires WOL should be "stick".
I see two different cases:

Suspend/resume: The WoL state in the kernel is probably kept across
such a cycle. If so, you would expect another suspend/resume to also
work, without needs to reconfigure it.
Trying this scenario (suspend/resume) from my side. In this case WoL should be enabled in the HW. For Marvell PHY to generate WoL interrupt we need to clear WoL status.
Above mentioned change required to make this happen. Please share your thoughts on this.

Boot from powered off: If the interrupt just enables the power supply,
it is possible to wake up after a shutdown. There is no state kept, so
WoL will be disabled in the kernel. So WoL should also be disabled in
the hardware.