Re: [PATCH v4 1/5] dt-bindings: reset: Add AOSS reset bindings for SDM845 SoCs

[Sibi S]

Hi Philipp,

Thanks for the review

On 04/27/2018 03:54 PM, Philipp Zabel wrote:
> Hi Sibi,
>
> On Wed, 2018-04-25 at 20:38 +0530, Sibi Sankar wrote:
> > Add SDM845 AOSS (always on subsystem) reset controller binding
> >
> > Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
> > ---
> >   .../bindings/reset/qcom,aoss-reset.txt        | 52 +++++++++++++++++++
> >   include/dt-bindings/reset/qcom,sdm845-aoss.h  | 17 ++++++
> >   2 files changed, 69 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
> >   create mode 100644 include/dt-bindings/reset/qcom,sdm845-aoss.h
> >
> > diff --git a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
> > new file mode 100644
> > index 000000000000..e5201de9a314
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
> > @@ -0,0 +1,52 @@
> > +Qualcomm AOSS Reset Controller
> > +======================================
> > +
> > +This binding describes a reset-controller found on AOSS (always on subsystem)
> > +for Qualcomm SDM845 SoCs.
> > +
> > +Required properties:
> > +- compatible:
> > +	Usage: required
> > +	Value type: <string>
> > +	Definition: must be:
> > +		    "qcom,sdm845-aoss-reset"
> > +
> > +- reg:
> > +	Usage: required
> > +	Value type: <prop-encoded-array>
> > +	Definition: must specify the base address and size of the register
> > +	            space.
> > +
> > +- #reset-cells:
> > +	Usage: required
> > +	Value type: <uint>
> > +	Definition: must be 1; cell entry represents the reset index.
> > +
> > +Example:
> > +
> > +aoss_reset: qcom,reset-controller@b2e0100 {
>
> The node name should be "reset-controller", not "qcom,reset-controller"
>
> > +	compatible = "qcom,sdm845-aoss-reset";
> > +	reg = <0xc2b0000 0x21000>;
>
> The address here should match the address part of the node name above.

sure will change them

> Apart from those two nitpicks, the binding looks good to me.
>
> regards
> Philipp

--
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc, is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project