Re: [PATCH v4 2/5] reset: qcom: AOSS (always on subsystem) reset controller
From: Philipp Zabel
Date: Fri Apr 27 2018 - 07:54:19 EST
On Fri, 2018-04-27 at 16:45 +0530, Sibi S wrote:
> > > + /* Wait 6 32kHz sleep cycles for reset */
> > > + usleep_range(200, 210);
> > 6 32 kHz cycles are about 188 Âs (184 Âs for 32.768 kHz).
> > Just out of curiosity, is the minimum increased to 200 Âs on purpose, or
> > to have a nice round number? The maximum seems oddly small, unless it is
> > essential to wait less than 7 cycles.
> anything above 188 Âs should be fine 200 Âs is just a round number.
> no it is not essential to wait less than 7 cycles so I can increase
> the max limit to 300 Âs.
Ok, thanks for the info.
> > The driver looks good to me now. I plan to apply patches 1 and 2 with
> > Rob's ack.
> > Is it ok to merge them independently from the remoteproc driver, or is
> > there a dependency?
> Yes it should be fine to merge them independently. I can add a dt entry
> to the dtsi and separate the 2 patches from the remoteproc patches if
> that helps ?
I plan to just pick up the reset DT binding documentation patch (1/5)
and the reset driver patch (2/5) then, whether they are sent separately
or as part of the larger remoteproc series does not matter to me.
The dtsi patch would have to go through the arm/qualcomm tree.
I can put the reset patches onto a separate branch that could be pulled
into the qcom tree ahead of the dtsi change, or you could send the dtsi
change with numbers at first, and only replace them with the header
defines after patch 1 is merged through the reset tree.