Re: [v2, 1/3] staging: fsl-dpaa2/eth: Add support for hardware timestamping

From: Greg Kroah-Hartman
Date: Fri Apr 27 2018 - 10:59:08 EST

On Thu, Apr 26, 2018 at 06:23:47PM +0800, Yangbo Lu wrote:
> From: Ioana Radulescu <ruxandra.radulescu@xxxxxxx>
> Hardware timestamping is supported both on Rx and Tx paths.
> On Rx, timestamping is enabled for all frames. On Tx, we
> only instruct the hardware to timestamp the frames marked
> accordingly by the stack.
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@xxxxxxx>
> Signed-off-by: Yangbo Lu <>
> ---
> Changes for v2:
> - Addressed sparse issues.
> - Used tx_tstamp/rx_tstamp instead of ts_tx_en/ts_rx_en.
> - Used DPAA2_PTP_CLK_PERIOD_NS instead.

Why are you adding new features to this driver instead of working on
getting it out of the staging directory? What is remaining left to do
to get it moved out?


greg k-h